Typo in USBSerial.h function prevents compilation #11260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rvasquez6089, thank you for your changes. |
0xc0170
approved these changes
Aug 20, 2019
|
CI started |
|
CI restarted |
|
cc @mbed-os-test - also this one - client test failing |
Known issue, will be restarted once fixed |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
How is that tested that we didn't catch this issue? @jamesbeyond |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In one of attach function calls in the USBSerial class, the object pointer is flipped with the location of the static location of the function. This prevents code from compiling when using the the attach function properly. Just a small typo that needed fixing.
rx = mbed::Callback<void()>(mptr, tptr);<--- Incorrectrx = mbed::Callback<void()>(tptr, mptr);<----Correctto match this function prototype --->
Callback(U *obj, R(T::*method)())Pull request type
Reviewers
Release Notes